Don't ignore warnings from eslint #243
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The plugin doesn't seemt to correctly recognize handleSubmit as an event handler function, and warns about not having reactivity
The event handler bindings on native elements are not reactive. So, we wrap the call to `props.close` within a function call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 008bfdb we fixed an error where we accidentally had some properties "lose" their reactivity, which should've been caught by the eslint-plugin-solid's warnings. But, we disable eslint's warnings in CI because, there were too many of them.
This commit prevents having warnings from eslint, which means we would be forced to think harder about the code and re-write it, or disable it in exceptional cases if the linter is giving a false positive.