Skip to content

Conversation

@inducer
Copy link
Owner

@inducer inducer commented Dec 4, 2025

Resumed from #139.


Relevant parts of summary from #139 follow:

Remaining porting issues

Upstream / downstream PRs

Speculative TODOs

  • Should some classes clone the actx? Here e.g. SumpyTreeIndependentDataForWrangler but also in boxtree.
    • The big worry is that cloning throws away any caches on the actx.
    • Pretty much all *Builder classes can be functions + all other memoized kernels can be functions, but should leave that for later since it can be done without breaking the world.
  • Rip out the timing stuff (not sure, just mentioned by @inducer at some point).
    • This would also need to be done in boxtree?
  • Add an array context to do the timing stuff? (now Make an array context to handle timing #259)

@inducer inducer force-pushed the towards-array-context-merge branch from f214429 to 53b6fc3 Compare December 9, 2025 22:40
@inducer inducer force-pushed the towards-array-context-merge branch from 6f1f569 to 22b9b8f Compare December 10, 2025 21:39
@inducer
Copy link
Owner Author

inducer commented Dec 10, 2025

FYI: As in boxtree, I've moved towards annotating with ArrayContext instead of PyOpenCLArrayContext. I like that direction because it conveys the ambition (cough) that all this will work with any actx. It also prevents having to splatter actx-type asserts everywhere downstream. If you hate it, it's a single commit that could be unwound.

@inducer
Copy link
Owner Author

inducer commented Dec 10, 2025

FYI2: The local tests are now passing here, so maybe this can become #139? (I.e. I would push this code there?) Does that sound OK?

@alexfikl
Copy link
Collaborator

FYI2: The local tests are now passing here, so maybe this can become #139? (I.e. I would push this code there?) Does that sound OK?

Definitely! I'm fine with continuing the work here too, whatever's more convenient.

@inducer inducer force-pushed the towards-array-context-merge branch from f8a618b to 5a00e5f Compare January 1, 2026 14:27
@inducer
Copy link
Owner Author

inducer commented Jan 1, 2026

Uh-oh. I think I may have force-pushed over two commits of yours just now:

image

Do you still have those? Could you reapply them?

@alexfikl
Copy link
Collaborator

alexfikl commented Jan 1, 2026

Do you still have those? Could you reapply them?

Done! 😁

EDIT: I think the pytential job is confused because we're now pointing to boxtree main?

@inducer inducer marked this pull request as ready for review January 1, 2026 16:44
@inducer inducer enabled auto-merge (squash) January 1, 2026 16:45
@inducer inducer merged commit 5216e4a into main Jan 1, 2026
9 checks passed
@inducer inducer deleted the towards-array-context-merge branch January 1, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants