Allow for asynchronous resolution of crypto library#9
Open
zachgibb wants to merge 1 commit intoindutny:masterfrom
Open
Allow for asynchronous resolution of crypto library#9zachgibb wants to merge 1 commit intoindutny:masterfrom
zachgibb wants to merge 1 commit intoindutny:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In React Native, the standard node libraries are not available, so the
cryptolibrary needs to be aliased to point to react-native-crypto.However, in order to re-implement crypto, the Diffie-Hellman methods are pulled in from crypto-browserify/diffie-hellman, which, in turn depends on this project.
This project itself requires
crypto, so we have a nice dependency loop which causes the whole thing to crash.If, on the other hand, we allow for
require('crypto')to happen at the time of the call ofRand.prototype._rand, all of the files can get read without introducing a loop and the dependency tree can get sorted out properly.