Handle the case if json tag was not overwritten#23
Open
Conversation
PumpkinSeed
requested changes
Jan 31, 2023
Member
PumpkinSeed
left a comment
There was a problem hiding this comment.
Actually what you should do, you have to get the o.goStructTags, and if there is a tag from the override than 1. override the value if it exists in the o.goStructTags, 2. add it if it's not exists. The current solution somehow overcomplicate the problme. Correct me if I'm wrong and you are doing this.
Author
|
Basically, my implementation is doing the same in the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the
jsontag was not present in the go_struct_tags option, the lib would use the defaultjsontag, generated by protobuf.#22