fix: remove deprecation for implicitly nullable parameter types#161
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #161 +/- ##
=========================================
Coverage 75.09% 75.09%
- Complexity 433 437 +4
=========================================
Files 25 25
Lines 1104 1104
=========================================
Hits 829 829
Misses 275 275
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@bednar Hey, could you maybe take a look at this? I really have no idea what the Codecov stuff is and don't wanna sign anything. Maybe you could implement and merge this yourself? This is flooding our deprecation logs and needs to be fixxed. 😿 Thank you very much! 😀 Source: https://wiki.php.net/rfc/deprecate-implicitly-nullable-types |
|
Jakub Bednar is on holiday this week, so I took your change and added it using a new branch and PR on our side (#164). This has just been merged. I'm looking to releasing this with another PR shortly. |
|
#164 covers this change. Closing |
|
@jesperbeisner |
|
Thank you! :) |
Proposed Changes
Remove deprecation for implicitly nullable parameter types since php 8.4
Checklist