fix: PHP 8.4 - fgetcsv argument escape provided explicitly#163
fix: PHP 8.4 - fgetcsv argument escape provided explicitly#163bednar merged 5 commits intoinfluxdata:masterfrom
Conversation
As of PHP 8.4.0, depending on the default value of escape is deprecated. It needs to be provided explicitly either positionally or by the use of named arguments.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #163 +/- ##
=========================================
Coverage 75.09% 75.09%
Complexity 433 433
=========================================
Files 25 25
Lines 1104 1104
=========================================
Hits 829 829
Misses 275 275
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bednar
left a comment
There was a problem hiding this comment.
@LuKo thanks for your PR 👍
Can you please cover your changes in https://github.com/influxdata/influxdb-client-php/blob/master/tests/FluxCsvParserTest.php?
Thx
|
I’m not sure how to do it when it’s just an update to the function call syntax without changing the logic. Could I kindly ask you to make it now, and I will learn it for the next time? Thank you very much. |
|
Ohh, sorry for the misunderstanding. Now it’s clear to me. LGTM 🚀 |
bednar
left a comment
There was a problem hiding this comment.
Ohh, sorry for the misunderstanding. Now it’s clear to me. LGTM 🚀
Closes #162
Proposed Changes
Added argument
escape.Checklist