Aidan/support unknown fields #151
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 3, 2025 12:43
Signed-off-by: Aidan Jensen <aidan.jensen@robust.ai>
Signed-off-by: Aidan Jensen <aidan.jensen@robust.ai>
Signed-off-by: Aidan Jensen <aidan.jensen@robust.ai>
aidandj
force-pushed
the
aidan/support-unknown-fields
branch
from
17e6e57 to
1a05be5
Compare
Signed-off-by: Aidan Jensen <aidan.jensen@robust.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not intended to go in as is, but is some work I started to support a possible upcoming feature that I've been using in a project.
The feature adds unknown field tracking as an option to prost, and does so by adding a public struct member with a configurable name. To make pbjson work correctly with this change, pbjson must be updated to set that struct field to default when constructing.
Protobuf JSON does not maintain unknown fields, so there's no work to do in parsing or data management, just a configurable option that a user can use to set the field they are using with their prost generated code.
I enabled it for testing, and everything passed.
Another option is to just add a boolean
unknown_field_support, and then generate a..Default::default()for the struct creation.