fix: sql negation #3812
Draft
fix: sql negation #3812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnsrnhld
commented
Nov 13, 2025
| .withNegation(false); | ||
|
|
||
| QueryStep queryStep = converted.getLastConvertedStep(); | ||
| if (negationNode.getDateAction() != DateAggregationAction.NEGATE) { |
Collaborator
Author
There was a problem hiding this comment.
Die Stelle hier meine ich. Ggf. müssten wir darüber nochmal sprechen.
Collaborator
There was a problem hiding this comment.
Ich verstehe die Frage nicht ganz. Geht die negierte Datumsaggregation für dateMode=Logical jetzt nicht mehr?
awildturtok
reviewed
Nov 17, 2025
Collaborator
awildturtok
left a comment
awildturtok
left a comment
There was a problem hiding this comment.
sieht soweit gut aus, muss mir noch das SQL anschauen.
Comment on lines
79
to
81
| if (queriesToJoin.stream().anyMatch(QueryStep::isNegate)) { | ||
| List<QueryStep> nonNegateSteps = queriesToJoin.stream().filter(Predicate.not(QueryStep::isNegate)).toList(); | ||
| List<QueryStep> negateSteps = queriesToJoin.stream().filter(QueryStep::isNegate).toList(); |
Collaborator
There was a problem hiding this comment.
Hier wäre ein partitioningBy schöner denke ich.
Collaborator
There was a problem hiding this comment.
Also
partitioned = queriesToJoin.partitionBy(isNegate);
if(!partitioned.get(true).isEmpty()){
...
}|
|
||
| return QueryStep.builder() | ||
| .cteName(context.getNameGenerator().joinedNodeName(logicalOperation) + NEGATED_CTE_SUFFIX) | ||
| .selects(nonNegateJoined.getQualifiedSelects()) |
Collaborator
There was a problem hiding this comment.
Die selects von negated werden auch ausgegeben.
| .withNegation(false); | ||
|
|
||
| QueryStep queryStep = converted.getLastConvertedStep(); | ||
| if (negationNode.getDateAction() != DateAggregationAction.NEGATE) { |
Collaborator
There was a problem hiding this comment.
Ich verstehe die Frage nicht ganz. Geht die negierte Datumsaggregation für dateMode=Logical jetzt nicht mehr?
Collaborator
Author
|
@awildturtok Der hier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Das reverted alles, was bisher die nicht korrekt funktionierende Negation implementier hat.
Nur bzgl. invertiertes Validity Date bin ich mir noch unsicher - brauchen wir das irgendwie? Ich habe die entsprechende Stelle nochmal kommentiert.