umber.h: Don't set string size in umber_class_new params#16
Merged
Conversation
I initially thought these parameter annotations would indicate a maximum
size array that could be passed to them. Unfortunately they actually
indicate an exact size to be passed. When compiling with certain
compilers:
gv.c:28:15: error: ‘umber_class_new’ reading 32 bytes from a region of size 12 [-Werror=stringop-overread] 28 | cls = umber_class_new("aqua.kos.gv", UMBER_LVL_INFO, "KOS GrapeVine interaction."); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ gv.c:28:15: note: referencing argument 1 of type ‘const char[32]’
The solution is just to turn these into boring old pointers and to just
document the max sizes in the doc comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I initially thought these parameter annotations would indicate a maximum size array that could be passed to them. Unfortunately they actually indicate an exact size to be passed. When compiling with certain compilers:
The solution is just to turn these into boring old pointers and to just document the max sizes in the doc comment.