Skip to content

Conversation

@toxix
Copy link
Contributor

@toxix toxix commented Feb 5, 2015

This adds sepperate gemfiles for all actualy released versions of rails 4 and active record 4. It also support ruby 2.2.

you may prefere merging this over the minor changes from #62 or #61

toxix and others added 2 commits February 5, 2015 00:35
@toxix
Copy link
Contributor Author

toxix commented Feb 5, 2015

Don't know wat to do with the failing installation of gems when activrecord/rails is used with jruby-19mode

@ryedog
Copy link
Collaborator

ryedog commented Sep 30, 2015

the issue is the new statement cache in ActiveRecord 4.2.

It doesn't ask for a scope unless skip_statement_cache? returns true
and skip_statement_cache? returns false unless there is already a scope
but since protector is dynamically adding the scope on request of the scope there is not scope at the time skip_statement_cache? is called.

there's a simple fix (although a little rough to hunt down) https://github.com/Updater/protector/pull/2/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants