Skip to content

Conversation

@m7pr
Copy link
Contributor

@m7pr m7pr commented Feb 3, 2026

Looks like this output is not used anywhere
It is used only in this PR #337
but I can always change table_out_modal to table_out_main

Looks like this output is not used anywhere

Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com>
@m7pr m7pr requested review from gogonzo and llrs-roche February 3, 2026 16:29
@m7pr m7pr added the core label Feb 3, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

Unit Tests Summary

  1 files   16 suites   1m 59s ⏱️
170 tests 167 ✅ 0 💤 0 ❌ 3 🔥
391 runs  388 ✅ 0 💤 0 ❌ 3 🔥

For more details on these errors, see this check.

Results for commit e804de5.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2026

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
plot_with_settings_ui 💔 $52.45$ $+1.48$ $0$ $0$ $0$ $0$
table_with_settings_ui 💔 $33.12$ $+1.96$ $0$ $0$ $0$ $0$

Results for commit 3a21736

♻️ This comment has been updated with latest results.

@m7pr
Copy link
Contributor Author

m7pr commented Feb 5, 2026

Closing, looks like tests fail when this is removed

@m7pr m7pr closed this Feb 5, 2026
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant