Explicitly inform build tools about package structure#157
Merged
Baharis merged 3 commits intoinstamatic-dev:mainfrom Feb 18, 2026
Merged
Explicitly inform build tools about package structure#157Baharis merged 3 commits intoinstamatic-dev:mainfrom
Baharis merged 3 commits intoinstamatic-dev:mainfrom
Conversation
Member
Author
|
Given no objection, I will merge this PR alongside #158 and include it in a new release 2.2.1 by Wednesday. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #156, changes recently pushed to pyproject.toml broke packaging of Instamatic. Before v2.2.0, setuptools/build relied on automated discovery: the path to package was guessed rather than specified anywhere. I suggest to fix Issue #156 in a way where instead of reverting to the old default behavior, the packages are explicitly informed about the repository structure:
The solution has been tested using a GitHub action on this branch, resulting in a wheel structure that is once more complete: https://github.com/Baharis/instamatic/actions/workflows/build-artifacts.yml. The first run of the workflow "successfully" builds and empty package, while the second fails because of another Instamatic issue that I see better fit addressed in another PR. Ultimately, from the second build, I have downloaded the built package, confirmed it has all the files, installed it in a clear environment, and confirmed the tests run.