[MBL-19665][All] - Fix help menu E2E tests (strings and some urls has changed on backend). #3481
Conversation
refs: MBL-19665 affects: Student, Teacher, Parent release note: -
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
This PR updates help menu URLs and string constants across the Parent, Student, and Teacher apps. The changes migrate from old Canvas community URLs to new Instructure community URLs and update Play Store links for the "Share Love" feature.
Positive Aspects
- Good consistency in updating URLs across all three apps (Parent, Student, Teacher)
- Appropriate use of
market://scheme for Play Store links - String improvements add proper punctuation to subtitles for better consistency
Issues to Address
- Inconsistent capitalization in
StringConstants.kt:54- "conferences in Canvas" uses lowercase "canvas" while it should be capitalized as a proper noun - Test reliability concern in
HelpPage.kt:143-147- Changing fromallOftoanyOfmakes intent matching less strict, which could lead to false positives. This needs clarification or documentation about why the change is necessary.
Additional Observations
The test changes appear related to supporting the new market:// URL scheme, which may behave differently than https:// URLs in intent matching. If this is the reason for the anyOf change, it would be helpful to document this with a code comment for future maintainers.
Overall, this is a straightforward URL update, but the test assertion change needs careful consideration to ensure we're not reducing test effectiveness.
| object Teacher { | ||
| const val CONFERENCE_GUIDES_TITLE = "Conference Guides for Remote Classrooms" | ||
| const val CONFERENCE_GUIDES_SUBTITLE = "Get help on how to use and configure conferences in canvas." | ||
| const val CONFERENCE_GUIDES_SUBTITLE = "Get help on how to use and configure conferences in Canvas." |
There was a problem hiding this comment.
Inconsistent capitalization: The subtitle says "conferences in Canvas" but uses lowercase "canvas". Consider using "Canvas" with a capital C to match the proper noun usage throughout the codebase and the title above it.
| val expectedIntent = CoreMatchers.anyOf( | ||
| CoreMatchers.allOf( | ||
| IntentMatchers.hasAction(android.content.Intent.ACTION_VIEW), | ||
| IntentMatchers.hasData(expectedURL) | ||
| ), |
There was a problem hiding this comment.
Test reliability concern: Changing from allOf to anyOf makes the test less strict. This means the test will pass if either the ACTION_VIEW intent OR the bundled extras match, rather than requiring all conditions to be true.
This could lead to false positives where the wrong URL is opened but the test still passes. Consider:
- Keeping
allOfif you need to verify both conditions - Adding a comment explaining why
anyOfis necessary (e.g., if different browsers/Android versions handle intents differently) - Ensuring this change is intentional for the new Play Store URLs that use
market://scheme
🧪 Unit Test Results✅ 📱 Parent App
✅ 📱 Student App
✅ 📱 Teacher App
✅ 🌅 Horizon
✅ 📦 Submodules
📊 Summary
Last updated: Fri, 16 Jan 2026 19:00:05 GMT |
📊 Code Coverage Report✅ Student
✅ Teacher
✅ Pandautils
📈 Overall Average
|
|
Parent Install Page |
|
Teacher Install Page |
|
Student Install Page |
Fix help menu E2E tests (strings and some urls has changed on backend).
refs: MBL-19665
affects: Student, Teacher, Parent
release note: -