Skip to content

fix: config command script LKM and binary dependencies #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harp-intel merged 1 commit into from
Jan 8, 2026
Merged

fix: config command script LKM and binary dependencies #607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions cmd/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import (
"perfspect/internal/app"
"perfspect/internal/workflow"

"perfspect/internal/cpus"
"perfspect/internal/progress"
"perfspect/internal/report"
"perfspect/internal/script"
Expand Down Expand Up @@ -220,32 +219,7 @@ func runCmd(cmd *cobra.Command, args []string) error {
return nil
}

// prepareTarget prepares the target for configuration changes
// almost all set scripts require the msr kernel module to be loaded and
// use wrmsr and rdmsr, so we do that here so that the goroutines for the
// set scripts can run concurrently without conflicts
func prepareTarget(myTarget target.Target, localTempDir string) (err error) {
prepareScript := script.ScriptDefinition{
Name: "prepare-target",
ScriptTemplate: "exit 0",
Superuser: true,
Vendors: []string{cpus.IntelVendor},
Depends: []string{"wrmsr", "rdmsr"},
Lkms: []string{"msr"},
}
_, err = runScript(myTarget, prepareScript, localTempDir)
return err
}

func setOnTarget(cmd *cobra.Command, myTarget target.Target, flagGroups []flagGroup, localTempDir string, channelError chan error, statusUpdate progress.MultiSpinnerUpdateFunc) {
// prepare the target for configuration changes
_ = statusUpdate(myTarget.GetName(), "preparing target for configuration changes")
if err := prepareTarget(myTarget, localTempDir); err != nil {
_ = statusUpdate(myTarget.GetName(), fmt.Sprintf("error preparing target: %v", err))
slog.Error(fmt.Sprintf("error preparing target %s: %v", myTarget.GetName(), err))
channelError <- nil
return
}
var statusMessages []string
_ = statusUpdate(myTarget.GetName(), "updating configuration")
var setErrs []error // collect errors but continue setting other flags
Expand Down
78 changes: 42 additions & 36 deletions cmd/config/set.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,8 @@ func setLlcSize(desiredLlcSize float64, myTarget target.Target, localTempDir str
ScriptTemplate: fmt.Sprintf("wrmsr -a 0xC90 %d", msrVal),
Superuser: true,
Vendors: []string{cpus.IntelVendor},
// Depends: []string{"wrmsr"},
// Lkms: []string{"msr"},
Depends: []string{"wrmsr"},
Lkms: []string{"msr"},
}
_, err = runScript(myTarget, setScript, localTempDir)
if err != nil {
Expand Down Expand Up @@ -222,8 +222,8 @@ func setSSEFrequency(sseFrequency float64, myTarget target.Target, localTempDir
ScriptTemplate: fmt.Sprintf("wrmsr 0x774 %d", value),
Superuser: true,
Vendors: []string{cpus.IntelVendor},
// Depends: []string{"wrmsr"},
// Lkms: []string{"msr"},
Depends: []string{"wrmsr"},
Lkms: []string{"msr"},
}
} else {
value := freqInt << uint(2*8)
Expand All @@ -232,8 +232,8 @@ func setSSEFrequency(sseFrequency float64, myTarget target.Target, localTempDir
ScriptTemplate: fmt.Sprintf("wrmsr 0x199 %d", value),
Superuser: true,
Vendors: []string{cpus.IntelVendor},
// Depends: []string{"wrmsr"},
// Lkms: []string{"msr"},
Depends: []string{"wrmsr"},
Lkms: []string{"msr"},
}
}
} else {
Expand All @@ -247,8 +247,8 @@ func setSSEFrequency(sseFrequency float64, myTarget target.Target, localTempDir
ScriptTemplate: fmt.Sprintf("wrmsr -a 0x1AD %d", value),
Superuser: true,
Vendors: []string{cpus.IntelVendor},
// Depends: []string{"wrmsr"},
// Lkms: []string{"msr"},
Depends: []string{"wrmsr"},
Lkms: []string{"msr"},
}
}
_, err = runScript(myTarget, setScript, localTempDir)
Expand Down Expand Up @@ -440,6 +440,8 @@ func setSSEFrequencies(sseFrequencies string, myTarget target.Target, localTempD
ScriptTemplate: fmt.Sprintf("wrmsr 0x774 %d", value),
Superuser: true,
Vendors: []string{cpus.IntelVendor},
Depends: []string{"wrmsr"},
Lkms: []string{"msr"},
}
} else {
// For non-intel_pstate driver
Expand All @@ -450,6 +452,8 @@ func setSSEFrequencies(sseFrequencies string, myTarget target.Target, localTempD
ScriptTemplate: fmt.Sprintf("wrmsr 0x199 %d", value),
Superuser: true,
Vendors: []string{cpus.IntelVendor},
Depends: []string{"wrmsr"},
Lkms: []string{"msr"},
}
}
} else {
Expand All @@ -464,6 +468,8 @@ func setSSEFrequencies(sseFrequencies string, myTarget target.Target, localTempD
ScriptTemplate: fmt.Sprintf("wrmsr -a 0x1AD %d", value),
Superuser: true,
Vendors: []string{cpus.IntelVendor},
Depends: []string{"wrmsr"},
Lkms: []string{"msr"},
}
}

Expand Down Expand Up @@ -546,8 +552,8 @@ func setUncoreFrequency(maxFreq bool, uncoreFrequency float64, myTarget target.T
Vendors: []string{cpus.IntelVendor},
MicroArchitectures: []string{cpus.UarchGNR, cpus.UarchGNR_D, cpus.UarchSRF, cpus.UarchCWF},
Superuser: true,
// Depends: []string{"rdmsr"},
// Lkms: []string{"msr"},
Depends: []string{"rdmsr"},
Lkms: []string{"msr"},
}
scriptOutput, err := workflow.RunScript(myTarget, getScript, localTempDir, false)
if err != nil {
Expand Down Expand Up @@ -576,8 +582,8 @@ func setUncoreFrequency(maxFreq bool, uncoreFrequency float64, myTarget target.T
Superuser: true,
Vendors: []string{cpus.IntelVendor},
MicroArchitectures: []string{cpus.UarchGNR, cpus.UarchGNR_D, cpus.UarchSRF, cpus.UarchCWF},
// Depends: []string{"wrmsr"},
// Lkms: []string{"msr"},
Depends: []string{"wrmsr"},
Lkms: []string{"msr"},
}
_, err = runScript(myTarget, setScript, localTempDir)
if err != nil {
Expand All @@ -592,8 +598,8 @@ func setTDP(power int, myTarget target.Target, localTempDir string) error {
ScriptTemplate: "rdmsr 0x610",
Superuser: true,
Vendors: []string{cpus.IntelVendor},
// Lkms: []string{"msr"},
// Depends: []string{"rdmsr"},
Lkms: []string{"msr"},
Depends: []string{"rdmsr"},
}
readOutput, err := workflow.RunScript(myTarget, readScript, localTempDir, false)
if err != nil {
Expand All @@ -613,8 +619,8 @@ func setTDP(power int, myTarget target.Target, localTempDir string) error {
ScriptTemplate: fmt.Sprintf("wrmsr -a 0x610 %d", newVal),
Superuser: true,
Vendors: []string{cpus.IntelVendor},
// Depends: []string{"wrmsr"},
// Lkms: []string{"msr"},
Depends: []string{"wrmsr"},
Lkms: []string{"msr"},
}
_, err := runScript(myTarget, setScript, localTempDir)
if err != nil {
Expand Down Expand Up @@ -650,8 +656,8 @@ func setEPB(epb int, myTarget target.Target, localTempDir string) error {
ScriptTemplate: "rdmsr " + msr,
Vendors: []string{cpus.IntelVendor},
Superuser: true,
// Lkms: []string{"msr"},
// Depends: []string{"rdmsr"},
Lkms: []string{"msr"},
Depends: []string{"rdmsr"},
}
readOutput, err := runScript(myTarget, readScript, localTempDir)
if err != nil {
Expand All @@ -671,8 +677,8 @@ func setEPB(epb int, myTarget target.Target, localTempDir string) error {
ScriptTemplate: fmt.Sprintf("wrmsr -a %s %d", msr, msrValue),
Superuser: true,
Vendors: []string{cpus.IntelVendor},
// Depends: []string{"wrmsr"},
// Lkms: []string{"msr"},
Depends: []string{"wrmsr"},
Lkms: []string{"msr"},
}
_, err = runScript(myTarget, setScript, localTempDir)
if err != nil {
Expand All @@ -691,8 +697,8 @@ func setEPP(epp int, myTarget target.Target, localTempDir string) error {
ScriptTemplate: "rdmsr 0x774", // IA32_HWP_REQUEST
Vendors: []string{cpus.IntelVendor},
Superuser: true,
// Lkms: []string{"msr"},
// Depends: []string{"rdmsr"},
Lkms: []string{"msr"},
Depends: []string{"rdmsr"},
}
stdout, err := runScript(myTarget, getScript, localTempDir)
if err != nil {
Expand All @@ -712,8 +718,8 @@ func setEPP(epp int, myTarget target.Target, localTempDir string) error {
ScriptTemplate: fmt.Sprintf("wrmsr -a 0x774 %d", eppValue),
Superuser: true,
Vendors: []string{cpus.IntelVendor},
// Depends: []string{"wrmsr"},
// Lkms: []string{"msr"},
Depends: []string{"wrmsr"},
Lkms: []string{"msr"},
}
_, err = runScript(myTarget, setScript, localTempDir)
if err != nil {
Expand All @@ -725,8 +731,8 @@ func setEPP(epp int, myTarget target.Target, localTempDir string) error {
ScriptTemplate: "rdmsr 0x772", // IA32_HWP_REQUEST_PKG
Vendors: []string{cpus.IntelVendor},
Superuser: true,
// Lkms: []string{"msr"},
// Depends: []string{"rdmsr"},
Lkms: []string{"msr"},
Depends: []string{"rdmsr"},
}
stdout, err = runScript(myTarget, getScript, localTempDir)
if err != nil {
Expand All @@ -746,8 +752,8 @@ func setEPP(epp int, myTarget target.Target, localTempDir string) error {
ScriptTemplate: fmt.Sprintf("wrmsr -a 0x772 %d", eppValue),
Superuser: true,
Vendors: []string{cpus.IntelVendor},
// Depends: []string{"wrmsr"},
// Lkms: []string{"msr"},
Depends: []string{"wrmsr"},
Lkms: []string{"msr"},
}
_, err = runScript(myTarget, setScript, localTempDir)
if err != nil {
Expand Down Expand Up @@ -829,8 +835,8 @@ func setPrefetcher(enableDisable string, myTarget target.Target, localTempDir st
ScriptTemplate: fmt.Sprintf("rdmsr %d", pf.Msr),
Vendors: []string{cpus.IntelVendor},
Superuser: true,
// Lkms: []string{"msr"},
// Depends: []string{"rdmsr"},
Lkms: []string{"msr"},
Depends: []string{"rdmsr"},
}
stdout, err := runScript(myTarget, getScript, localTempDir)
if err != nil {
Expand Down Expand Up @@ -860,8 +866,8 @@ func setPrefetcher(enableDisable string, myTarget target.Target, localTempDir st
ScriptTemplate: fmt.Sprintf("wrmsr -a %d %d", pf.Msr, newVal),
Superuser: true,
Vendors: []string{cpus.IntelVendor},
// Depends: []string{"wrmsr"},
// Lkms: []string{"msr"},
Depends: []string{"wrmsr"},
Lkms: []string{"msr"},
}
_, err = runScript(myTarget, setScript, localTempDir)
if err != nil {
Expand Down Expand Up @@ -929,8 +935,8 @@ func setC1Demotion(enableDisable string, myTarget target.Target, localTempDir st
ScriptTemplate: "rdmsr 0xe2",
Vendors: []string{cpus.IntelVendor},
Superuser: true,
// Lkms: []string{"msr"},
// Depends: []string{"rdmsr"},
Lkms: []string{"msr"},
Depends: []string{"rdmsr"},
}
stdout, err := runScript(myTarget, getScript, localTempDir)
if err != nil {
Expand Down Expand Up @@ -961,8 +967,8 @@ func setC1Demotion(enableDisable string, myTarget target.Target, localTempDir st
ScriptTemplate: fmt.Sprintf("wrmsr -a %d %d", 0xe2, newVal),
Vendors: []string{cpus.IntelVendor},
Superuser: true,
// Depends: []string{"wrmsr"},
// Lkms: []string{"msr"},
Depends: []string{"wrmsr"},
Lkms: []string{"msr"},
}
_, err = runScript(myTarget, setScript, localTempDir)
if err != nil {
Expand Down