This repository was archived by the owner on Jan 28, 2023. It is now read-only.
Move selector validity checking to vcpu_set_regs#250
Open
nevilad wants to merge 1 commit intointel:masterfrom
Open
Move selector validity checking to vcpu_set_regs#250nevilad wants to merge 1 commit intointel:masterfrom
nevilad wants to merge 1 commit intointel:masterfrom
Conversation
each vmentry. Signed-off-by: Alexey Romko <nevilad@yahoo.com>
Contributor
Author
|
Please don't apply this patch, I think I found an example where the TR.ar is corrupted by vmx. Need time to debug this. |
HaxmCI
added
CI:Build Fail
wcwang
force-pushed
the
master
branch
2 times, most recently
from
563eb1b to
6b942e3
Compare
wcwang
force-pushed
the
master
branch
2 times, most recently
from
b73a231 to
da1b8ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comments to cs.ar and tr.ar validity checking stating that these can be wrong set by qemu. But the checks were done before every vmentry with reading the values from vmcs and that is bad for performance. I moved the checks to vcpu_set_regs since qemu sets them through this function. I did not found any other places that write these to vmcs.