Add support to build UBI based images #2203
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To build UBI based images, set UBI=1 for the make command. For idxd or levelzero images, the build host needs to be registered to RH (subscription-manager) so packages can be installed from repositories. Signed-off-by: Tuomas Katila <tuomas.katila@intel.com>
idxd-config-initcontainer and gpu-levelzero are not built as they require repositories which are not available in GH. Signed-off-by: Tuomas Katila <tuomas.katila@intel.com>
Signed-off-by: Tuomas Katila <tuomas.katila@intel.com>
eero-t
reviewed
Jan 9, 2026
| COPY ./LICENSE /licenses/intel-device-plugins-for-kubernetes/LICENSE | ||
| FROM ${FINAL_BASE_DYN} | ||
|
|
||
| ARG UBI |
Contributor
There was a problem hiding this comment.
Set default value, like the other Docker files do.
| * intel-idxd-config-initcontainer | ||
| * intel-gpu-levelzero | ||
|
|
||
| To build these containers, the build host has to be registered via `subscription-manager`. Typically the host OS has to be RHEL or some rpm based Linux variant (e.g. Fedora). |
Contributor
There was a problem hiding this comment.
If it refers to format, use RPM, if to file extension use ".rpm"?
Suggested change
| To build these containers, the build host has to be registered via `subscription-manager`. Typically the host OS has to be RHEL or some rpm based Linux variant (e.g. Fedora). | |
| To build these containers, the build host has to be registered via `subscription-manager`. Typically the host OS has to be RHEL or some other RPM based Linux variant (e.g. Fedora). |
| UBI=1 BUILDER=podman make <image-name> | ||
| ``` | ||
|
|
||
| Docker doesn't support installing RPM packages with `subscription-manager`, so podman needs to be used. |
Contributor
There was a problem hiding this comment.
Suggested change
| Docker doesn't support installing RPM packages with `subscription-manager`, so podman needs to be used. | |
| Docker doesn't support installing RPM packages with `subscription-manager`, so Podman needs to be used. |
or:
Suggested change
| Docker doesn't support installing RPM packages with `subscription-manager`, so podman needs to be used. | |
| Docker doesn't support installing RPM packages with `subscription-manager`, so `podman` needs to be used. |
| BUILDER_NAME: ${{ matrix.builder }} | ||
| UBI: "1" | ||
| run: | | ||
| make ${IMAGE_NAME} BUILDER=${BUILDER_NAME} UBI=${UBI} |
Contributor
There was a problem hiding this comment.
I don't see Makefile passing UBI variable to build-image.sh?
| ## The RedHat build tool does not allow additional image build parameters. | ||
| ARG BUILD_BASE=rockylinux:9 | ||
| ARG FINAL_BASE_DYN=registry.access.redhat.com/ubi9/ubi-minimal:9.3 | ||
| ARG UBI=1 |
Contributor
There was a problem hiding this comment.
Default to 0, like the shell script does, in case UBI images require something extra to access?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1693