Avoid disabling THP when run job #531
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rli9
reviewed
Sep 25, 2025
lib/common.rb
Outdated
| PRCTL = Fiddle::Function.new( | ||
| LIBC['prctl'], | ||
| [Fiddle::TYPE_INT, Fiddle::TYPE_LONG, Fiddle::TYPE_LONG, Fiddle::TYPE_LONG, Fiddle::TYPE_LONG], | ||
| Fiddle::TYPE_INT) |
There was a problem hiding this comment.
Thanks, is it possible to do lazy initialization for these variables? So these are only called when below functions are called for the first time.
rli9
reviewed
Sep 25, 2025
lib/common.rb
Outdated
| PR_SET_THP_DISABLE = 41 | ||
| PR_GET_THP_DISABLE = 42 | ||
|
|
||
| def get_thp_disable |
There was a problem hiding this comment.
Kindly do a rake rubocop check, which may result in some comments.
THP is disabled in ruby after version 2.6. This will disable THP for job run by ruby too. Enable THP when run job to avoid the issue. Signed-off-by: Huang Ying <ying.huang@linux.alibaba.com>
hying-caritas
force-pushed
the
fix-ruby-thp
branch
from
4235a47 to
da94580
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THP is disabled in ruby after version 2.6. This will disable THP for job run by ruby too. Enable THP when run job to avoid the issue.