This repository was archived by the owner on Aug 30, 2024. It is now read-only.
Open
Conversation
save(g128 MTL 270Gflops bug on g32) add UT for gemv
Co-authored-by: Meng, Hengyu <hengyu.meng@intel.com>
Co-authored-by: Meng, Hengyu <hengyu.meng@intel.com>
enable 2d payload on Xe2
sunjiweiswift
force-pushed
the
xetla_int4_matB_col_major
branch
2 times, most recently
from
631b2a3 to
3d71451
Compare
DDEle
reviewed
Jul 29, 2024
Contributor
DDEle
left a comment
DDEle
left a comment
There was a problem hiding this comment.
If the config numbers of Xe2 and XeHpc are identical, maybe we can just add an alias instead of a complete class. A new class of config will add an additional of roughly 1/3 of the compilation/linkage workload while an alias is free.
BTW, what's the status of this PR?
Comment on lines
-34
to
-36
| template <> | ||
| struct load_store_attr_t<msg_type::block_2d, gpu_arch::XeHpc> { | ||
| /// HW limitation checks https://gfxspecs.intel.com/Predator/Home/Index/55490 |
Contributor
There was a problem hiding this comment.
There are multiple places with the gfxspecs link. I think they are helpful for internal developers. If they violate any company policies, they should be removed all at once in a separate PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
feature or bug fix or documentation or others
API changed or not
Description
detail description
Issues: xxx
Expected Behavior & Potential Risk
the expected behavior that triggered by this PR
How has this PR been tested?
how to reproduce the test (including hardware information)
Dependency Change?
any library dependency introduced or removed