-
Notifications
You must be signed in to change notification settings - Fork 66
Fallback fused RMS normalization fwd/bwd to CPU for functionality #2631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds CPU fallback support for fused RMS normalization operations on the XPU backend. When these operations are called on XPU devices, they will automatically fall back to CPU execution to ensure functionality until native XPU implementations are available.
- Adds
_fused_rms_normand_fused_rms_norm_backwardto the XPU fallback list
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Encountered multiple definition of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I’ve delayed these implementations listed in #1905 and plan to finish them in PT 2.11.
Performance outliers, please check!
|
|
This PR is converted to draft due to some new foundings. |
Fallback _fused_rms_norm and _fused_rms_norm_backward to CPU for XPU backend.