-
Notifications
You must be signed in to change notification settings - Fork 66
Fix wrong group usage in blocking p2p #2688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a deadlock issue in blocking P2P operations by removing unnecessary group API wrapping. The change addresses a problem where oneCCL 2021.17 can deadlock when a group contains only send or only recv operations.
- Removed
ccl::group_start()andccl::group_end()calls around P2P operations in blocking mode - Re-enabled previously skipped
test_batch_isend_irecvtest that was hanging due to this issue
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/xccl/ProcessGroupXCCL.cpp | Removed group API calls wrapping P2P operations to prevent deadlock |
| test/xpu/skip_list_dist.py | Re-enabled previously skipped test that was failing due to the deadlock issue |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pkourdis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Performance outliers, please check!
|
Performance outliers, please check!
|
In the default blocking P2P mode, there is no need to wrap P2P operations with group APIs. In oneCCL 2021.17, this pattern can actually lead to a deadlock when a group contains only
sendor onlyrecv. Removing the group calls around the P2P operations resolves this issue.disable_e2e
disable_ut