Merged
Conversation
|
larryrider
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What
Ticket: https://inxt.atlassian.net/browse/PB-6005
Due to problems with how we were handling migrations in
TypeORMsome things that we thought were migrated were indeed not, like the fieldfileIdfromfileto still beinguniquewhen it shouldn't. Right now we are still thinking about whatORMto use since we need more customization for migrations and we need them to be able to be run from the code itself, something that for example leavesPrismaORMoutside.However this had a problem with the native dependency
better-sqlite3since it was built to the electron node version instead of our local node version (electron doesn't use the same version as in our local). After many attempts, we have finally been able to build thebetter-sqlite3version to our local node version so we can run tests against a real in memory sqlite database. During this process we have been testing upgrading also thenodeversion to24and theelectronversion to40 (latest), so it's included also in this PR.So, what this PR does is to first prepare the code with real tests for sqlite so later we can tests the migrations in a better way:
rebuildcommand to buildbetter-sqlite3toelectronorlocal node, depending on what we need at the moment.I've disabled also the check PR size pipeline since 95% of the code modified are just tests.