This repository was archived by the owner on Jul 7, 2020. It is now read-only.
Use right configuration file on systemd systems#139
Open
mareg wants to merge 1 commit intoinviqa:masterfrom
Open
Use right configuration file on systemd systems#139mareg wants to merge 1 commit intoinviqa:masterfrom
mareg wants to merge 1 commit intoinviqa:masterfrom
Conversation
Contributor
|
Looks good 👍 But needs to be tested on Ubuntu first! |
Contributor
Author
|
@mlopes tested on Ubuntu and reported issues, I'll re-test later in the vm to see if I can mitigate that. Basically |
|
what happens if used on a Linux distro that doesn't use systemd? perhaps should check if systemd is in use and fallback to the removed code? |
Contributor
|
@mareg any update? Still using dock-cli? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in the documentation Fedora and Ubuntu (as of version
15.04) both usesystemdnow.I still believe
dock-clishould not use explicit IP but depend on what docker gets assigned, albeit this change will allow dock-cli to run on linux systems for now.