Mount bash_history to persist it among containers

[alexandrajulius]

This should solve the following issue
#627

[kierenevans]

I realised now that with my advice from yesterday, this won't survive harness updates (ws harness update existing and ws harness update fresh).

Perhaps it should end up being stored in the project root and added to the various application/skeleton/.gitignore files?

[alexandrajulius]

good point, we can certainly do that on Teufel, but where should i add it (empty .bash_history + .gitignore entry) to provide it in skeletons for new projects?

[andytson-inviqa]

@alexandrajulius https://github.com/inviqa/harness-base-php/search?q=filename%3Agitignore

[andytson-inviqa]

still needs gitignoring

[andytson-inviqa]

sorry, not that file, all the others in the skeleton directories

[alexandrajulius]

Ah nice :) I see where the skeletons are. Will revert this, and add to the other gitignores

[andytson-inviqa]

hmm we'll have another problem if the file has to exist, as tho the skeleton will be there on ws create, the file wont on any other person's clones

[andytson-inviqa]

I think you're right though, just we'd need to create the file some other way

[andytson-inviqa]

actually it wouldn't help on the ws create either.

It'd be something like the enable.sh running touch .bash_history

[andytson-inviqa]

otherwise if the file doesn't already exist, docker-compose would create a directory and bind that to the container, which isn't what we'd want

[alexandrajulius]

yes, that's what docker-compose does... i can add touch .bash_history to
src/_base/harness/config/events.yml

after('harness.install'): |
  #!bash
  ws enable

but then the file does not survive a refresh/install? I think it's better than not having it tho.
Alternatively people would have to create that file manually in their project root. Which is weird i think

[andytson-inviqa]

I'd suggest https://github.com/inviqa/harness-base-php/blob/995a60cf25b378708c812ff8b926829c39d825c8/src/_base/harness/scripts/enable.sh.twig rather than the after event itself.

The file will survive in this way, as touch only creates the file if it doesn't exist

[alexandrajulius]

@andytson-inviqa is this the right place?

[Chemaclass]

Hi! Any updates on this PR?

[Chemaclass]

@kierenevans @andytson-inviqa is there any missing work to be done in this PR? I just wonder why it was postpone that much, because it's already half a year open without any new feedback 🤔

[kierenevans]

@Chemaclass Unfortunately it's making the .bash_history as a directory via docker-compose:

➜  tmp-test git:(feature/persist-bash-history-among-containers) ls -la
total 336
drwxr-xr-x  9 kevans  1000   4096 May  6 10:04 .
drwxr-xr-x  7 kevans users   4096 May  6 10:03 ..
-rw-r--r--  1 kevans  1000    142 May  6 10:03 auth.json
drwxr-xr-x  2 root   root       6 May  6 10:03 .bash_history

I'll try to fix