Skip to content

feat: port docker harness console build args to override #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andytson-inviqa wants to merge 2 commits into
base: 2.0.x
Choose a base branch
from
Open

feat: port docker harness console build args to override #818

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fe947d
feat: port docker harness console build args to override
andytson-inviqa Jun 9, 2025
48a24ff
fix: include console build arg names in Dockerfile
andytson-inviqa Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/_base/_twig/docker-compose.yml/service/console.yml.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ services:
build:
context: ./
dockerfile: .my127ws/docker/image/console/Dockerfile
args: {{ to_nice_yaml(@('services.console.build.args')|default({}), 2, 8) }}
{% if @('app.build') == 'dynamic' %}
entrypoint: [/entrypoint.dynamic.sh]
command: [sleep, infinity]
Expand All @@ -22,6 +23,7 @@ services:
# deprecated, a later workspace release will disable by default
- traefik.enable=false
environment: {{ to_nice_yaml(deep_merge([
@('app.build') == 'dynamic' ? @('services.console.build.args')|default({}) : [],
@('services.php-base.environment'),
@('services.php-base.environment_dynamic'),
@('services.console.environment'),
Expand Down
7 changes: 7 additions & 0 deletions src/_base/docker/image/console/Dockerfile.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,13 @@ RUN apt-get update -qq \
&& rm -rf /var/lib/apt/lists/*
{% endif %}

{% set build_args=@('services.console.build.args')|default({})|filter(v => v is not empty) %}
{% if build_args %}
{% for name, value in build_args %}
ARG {{ name }}
{% endfor %}
{% endif %}

ENV APP_MODE={{ @('app.mode') }} \
APP_BUILD={{ @('app.build') }} \
ASSETS_DIR={{ @('assets.local') }}
Expand Down