You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before I go, there is some code which I think would be nice to have available for the public. Unfortunately, I will not have time to put too much time into this so maybe we can make it a combined effort.
The code I added here includes some volume operations such as reduction, min/max, etc, implemented using compute shaders and the feature level-sets (FLS), also implemented using compute shaders.
Everything works well enough to use it for standard cases (floating-point input fields). There are some things though that might need some attention.
One things that comes to my mind is the injection of implicit functions into the shader code for FLS. Right now I have a number of placeholders and do a simple string replace. Maybe this is better done with Peter's new shader snippet thingy.
Another thing is that I have also not handled anything other than 32 bit floating point volumes as input since that is all I ever needed. Maybe dispatching should be added here.
In the shader code for volume reduction you can see that I tried using different samplers for different input data. The code compiles fine but the shader won't work for certain inputs (IIRC integer >16 bit).
I wrote a fair bit of documentation but I haven't checked for completeness.
class 'VolumeChannelSplitGL' defines a default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator
class 'VolumeMinMaxGL' defines a default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator
class 'VolumeNormalizationGL' defines a default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator
enum 'ReductionOperator' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size
enum 'DisregardingStatus' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size
class 'VolumeReductionGL' defines a default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator
class 'VolumeShrinkToNormalRangeGL' defines a default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator
class 'ComputeUtilsModule' defines a default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator
class 'VolumeChannelSplitGLProcessor' defines a default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator
class 'VolumeMinMaxGLProcessor' defines a default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator
class 'VolumeNormalizationGLProcessor' defines a default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator
class 'VolumeReductionGLProcessor' defines a default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator
class 'VolumeShrinkToNormalRangeGLProcessor' defines a default destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator
enum 'DistanceMetric' uses a larger base type ('int', size: 4 bytes) than necessary for its value set, consider using 'std::uint8_t' (1 byte) as the base type to reduce its size
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PetiteViking
requested review from
ResearchDaniel,
martinfalk and
petersteneteg
petersteneteg
force-pushed
the
feature/featurelevelsets
branch
from
martinfalk
force-pushed
the
feature/featurelevelsets
branch
from
github-actions
bot
added
J: Integration Test Failure
and removed
J: Integration Test Failure
labels
Before I go, there is some code which I think would be nice to have available for the public. Unfortunately, I will not have time to put too much time into this so maybe we can make it a combined effort.
The code I added here includes some volume operations such as reduction, min/max, etc, implemented using compute shaders and the feature level-sets (FLS), also implemented using compute shaders.
Everything works well enough to use it for standard cases (floating-point input fields). There are some things though that might need some attention.
One things that comes to my mind is the injection of implicit functions into the shader code for FLS. Right now I have a number of placeholders and do a simple string replace. Maybe this is better done with Peter's new shader snippet thingy.
Another thing is that I have also not handled anything other than 32 bit floating point volumes as input since that is all I ever needed. Maybe dispatching should be added here.
In the shader code for volume reduction you can see that I tried using different samplers for different input data. The code compiles fine but the shader won't work for certain inputs (IIRC integer >16 bit).
I wrote a fair bit of documentation but I haven't checked for completeness.