You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merging #573 (27905a4) into master (d7b670b) will decrease coverage by 0.11%.
The diff coverage is 0.00%.
❗ Current head 27905a4 differs from pull request most recent head 253755f. Consider uploading reports for the commit 253755f to get more accurate results
No @OrlandoCo, I don't think so. It's the middleware who should process the disconnect (onRemovePeer). Just as the middleware processes the messages (onMessage). But I think that I might be convoluting the concept of a dc middleware here. It seems that data channel can have more than one middleware thus the DC chain structure. Also, that the concept of a middleware is really just a single function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change allows data channel middleware to register a callback for when a peer disconnects.
Reference issue
Fixes #572