This repository was archived by the owner on Jul 9, 2020. It is now read-only.
jake-review-simple-install#60
Open
JakeSCahill wants to merge 2 commits intoiotaledger-archive:developfrom
JakeSCahill:jake-review
Open
jake-review-simple-install#60JakeSCahill wants to merge 2 commits intoiotaledger-archive:developfrom JakeSCahill:jake-review
JakeSCahill wants to merge 2 commits intoiotaledger-archive:developfrom
JakeSCahill:jake-review
Conversation
Made the titles more consistent. All task titles should begin with a gerund if we are to be consistent. We should avoid using "we" everywhere. We are telling the readers what they should do, so we should address them personally by using "you". I think we can use we in the introductory paragraph, as in "In this guide, we use Ubuntu blah blah". To make things a bit clear, I stripped down each step to the bare essentials and added step numbers. If we need to include some information that is related to a step, we should use a **Note:** paragraph. I added some links that might be useful for readers. I was a bit confused by the Merkle tree section, so I separated the content into paragraphs and tried to rephrase some sentences.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Formatted the code snippets.