Multi-Robot setup and detection#767
Open
ipa-srd-rd wants to merge 14 commits intoipa320:indigo_devfrom
Open
Conversation
ipa-srd-rd
commented
Sep 25, 2018
ipa-srd-rd
commented
- added multi-robot and simulation arguments to launch files where needed
- removed absolute ros paths, since they do not allow namespacing
- updated sensor range to max range (~30m)
Author
fmessmer
requested changes
Sep 25, 2018
Member
fmessmer
left a comment
fmessmer
left a comment
There was a problem hiding this comment.
I'd prefer to keep all this "single_robot"
can you not outsource the multi_robot launch files to a new repo - say cob_multi_robots where you use subst_arg mechanism?
Member
|
there is an ugly file |
Author
Removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.