refactor: rewrite some flaky tests to testing/synctest #1087
+223
−236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor tests to use testing/synctest (Go 1.25) to fix data race where test code read from ResponseRecorder while middleware's internal goroutines were still writing.
lidel
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #1087 +/- ##
==========================================
- Coverage 61.18% 61.13% -0.06%
==========================================
Files 264 264
Lines 26230 26230
==========================================
- Hits 16049 16035 -14
- Misses 8508 8520 +12
- Partials 1673 1675 +2 see 13 files with indirect coverage changes 🚀 New features to boost your workflow:
|
lidel
changed the title
lidel
changed the title
…g/synctest refactor test to use testing/synctest (Go 1.25) to fix race condition where test code called AddCancels before the message queue goroutine finished marking items as "sent" in its internal state.
lidel
commented
Jan 15, 2026
| @@ -1,3 +1,5 @@ | |||
| //go:build go1.25 | |||
Member
Author
There was a problem hiding this comment.
@gammazero fysa i went with this, because we already run tests against both 1.24 (go this) and 1.25 (go next), so only running in 1.25+ feels like a good compromise (when go unified CI switches to 1.26 in february, tests will run on both this and next go release again)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor tests to use testing/synctest (Go 1.25)
7d2280f to fix flaky gateway tests
d5595ce fix flaky TestCancelOverridesPendingWants (my fix from flaky test: TestCancelOverridesPendingWants #626 did not fix all races)
Note
Most of diff is just indentation, it may be easier to review by ignoring whitespace changes: