fix(network): show what causes the test failure #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it appears calling stream.Close() too quickly is a problem?
Collaborator
Author
|
Follow up: this issue does NOT occur when doing a straight upgrade to v0.19.4 without going to 0.20.1 first. So I believe there is a transitive dependency difference between 0.19.4 and 0.20.1 that is the problem |
rvagg
force-pushed
the
rvagg/bindnode-registry
branch
from
c6e820d to
6565499
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals
Diagnose issue in test failure after upgrading libp2p from 0.16.1 -> 0.20.1.
Implementation
it appears calling stream.Close() too quickly returns an error? Adding a sleep fixes the problem. However, I don't understand why stream.Close would emit an error if you call it right after sending data.
cc: @marten-seemann @aschmahmann