Fix: Remove pull_request trigger from reusable workflow #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The claude-review.yml is a reusable workflow (workflow_call) and should not have a pull_request trigger. Individual repos will call this workflow via their own claude.yml files which contain the pull_request trigger. This fixes the workflow file issue that was causing failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The
claude-review.ymlworkflow had bothworkflow_callandpull_requesttriggers, which causes failures when other repositories try to use it as a reusable workflow.Solution
Removed the
pull_requesttrigger fromclaude-review.yml. This workflow should only be triggered viaworkflow_callfrom individual repository workflows.Impact
.github/workflows/claude.ymlfilespull_requesttriggerTesting
After merging, rerun the test PR in ht-json to verify Claude reviews work correctly.