Add bridge algorithm to unwrap #164
Conversation
oberonia78
changed the title
hfattahi
requested review from
bhawkins,
hfattahi,
seongsujeong and
xhuang-jpl
hfattahi
left a comment
hfattahi
left a comment
There was a problem hiding this comment.
Looks good to me. Would you please confirm if you have tested with latest constant PRF and Dithered data?
|
Currently, there is no issue in running the bridging algorithm for dithered mode but we don't see the differences with/without bridge algorithm, because there is no gap between subswaths for now. @hfattahi |
xhuang-jpl
left a comment
xhuang-jpl
left a comment
There was a problem hiding this comment.
Thank you @oberonia78 , LGTM, just a minor suggestion
| return output_arrays | ||
|
|
||
|
|
||
| def interpret_subswath_mask(subswath_mask, nodata=255): |
There was a problem hiding this comment.
Thank you @oberonia78, this is a very helpful function, would you please making it a generic function to put it here
There was a problem hiding this comment.
Good catch. I just moved it to utils.
Sorry I meant to try with constant PRF data. Have you tested? |
hfattahi
left a comment
hfattahi
left a comment
There was a problem hiding this comment.
LGTM! Based on offline discussion, the PR is tested on Quad-pol data as well.
* add bridge algorithm to unwrap * fix bug in reading mask * move function to utils * fix the bug --------- Co-authored-by: Jungkyo Jung <jungkyoj@nisar-adt-dev-5.jpl.nasa.gov>
3 participants
This PR adds the bridge functionality to the unwrap.
For the fixed PRF interferogram, the phase jumps occurs along the subswath boundaries. To minimize the issues, this PR masked out the invalid areas (partially focused area) using mask layer, then applies the bridge algorithm.