-
Notifications
You must be signed in to change notification settings - Fork 65
Update InSAR descriptions #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update InSAR descriptions #201
Conversation
hfattahi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nemo794 . LGTM. I compared with the PIX XMLs and they look consistent.
2a655bc to
31b49dd
Compare
xhuang-jpl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nemo794 . LTGM, but I am testing it now, and will approve it once it is done without any issues.
xhuang-jpl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No InSAR failure after testing.
|
Thank you for your reviews, @hfattahi and @xhuang-jpl ! And thank you for the sample files, @xhuang-jpl ! Looks like I missed a hyphen (see newest commit), but otherwise everything checks out 🎉 . @Tyler-g-hudson , once the CI system completes, please feel free to merge this PR if I'm too slow to push the button. Thank you all! |
* GUNW, GOFF metadata tweaks * RIFG, RUNW, GUNW metadata tweaks * remove hyphen from least-significant --------- Co-authored-by: Samantha C. Niemoeller <samantha.c.niemoeller@jpl.nasa.gov>
The QA XML Checker has identified several InSAR datasets where the description is inconsistent between the HDF5 and the XML.
This PR updates ISCE3 to output InSAR HDF5s with correct descriptions.
Note: I have not tested this branch; it'd be good to generate a quick HDF5s to make sure nothing broke!
Here are the logged ERRORs that this PR should resolve:
RIFG:
RUNW:
GUNW:
ROFF:
GOFF: