Add pulse and gradient fields as StreamItem of mrd format#36
Closed
kekeke21 wants to merge 4 commits intoismrmrd:mainfrom
Closed
Add pulse and gradient fields as StreamItem of mrd format#36kekeke21 wants to merge 4 commits intoismrmrd:mainfrom
kekeke21 wants to merge 4 commits intoismrmrd:mainfrom
Conversation
Contributor
Author
|
Feedback from MRD meeting: |
Contributor
Author
|
Feedback from MRD meeting: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #20 #21
This schema suggestion is to record the pulse sequence and gradients in addition to the existing k-space trajectory field at the
mrd_accquisition.ymlfield. While the trajectory field is kept for backward compatibility with the ISMRMRD format, the additional pulse and gradient fields can also be used to represent the measured gradients and pulses of the scanner.The phase in
mrd_pulse.ymlis the time course of the entire scan, exported from crystall oscillator phase data of the IDEA simulator for Siemens, which is not the real-time data from the scanner. At PR #35, adding phase field tomrd_acquisition.ymlwas suggested which partitions the phase array from pulse field for each corresponding acquisition. This design does allow inconsistent data between the phase saved in the Pulse field and the Acquisition field.We hope to review this with rounds of feedback sessions on the validity of this suggestion for the ISMRM community and also the availability of such data from Siemens and other scanner vendors.