Conversation
|
Bump YARDL_VERSION here too: mrd/.github/workflows/mrd_build.yml Line 14 in ed4e68c |
|
@kekeke21 Can you take a look at this, |
|
Thank you for all the tools in addition to the schema. Our current source of gradient data is IDEA simulator output, and we will fit it into this seq format. |
johnstairs
force-pushed
the
johnstairs/pulseq-types
branch
from
b93a040 to
bd9dc8d
Compare
| custom: string->string | ||
|
|
||
| # A sequence block that includes possible RF, gradient, and ADC events. | ||
| Block: !record |
There was a problem hiding this comment.
This is a very generic name. The MRD model has a larger scope than just pulse sequences, so qualifying these generic names that come from Pulseq, e.g. Block -> SequenceBlock, might be better.
What do you think about making the names more descriptive here, even if that means they differ from the Pulseq nomenclature? I'm also thinking Shape -> CompressedSamples (or similar).
There was a problem hiding this comment.
I agree with the naming as the nouns in protocol.yml leaves the first time users confusing. SequenceBlock or PulseqBlock sounds good, maybe SequenceShape or PulseqShape for Shape since the Shape field in pusleq can be either compressed or uncompressed format
| imageArray: ImageArray | ||
| pulseqDefinitions: PulseqDefinitions | ||
| blocks: Block* | ||
| rf: RFEvent |
There was a problem hiding this comment.
Rename to rfEvent, matching the rest of the StreamItem names.
| rf: RFEvent | ||
| arbitraryGradient: ArbitraryGradient | ||
| trapezoidalGradient: TrapezoidalGradient | ||
| adc: ADCEvent |
There was a problem hiding this comment.
Rename to adcEvent, matching the rest of the StreamItem names.
4 participants
As an experiment, adding Pulseq types to the MRD protocol, along with two Python tools
seq_to_mrdandmrd_to_seqto convert between.seqtext files and MRD.