use custom type for k8s intorstring for operator #1229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardwxn
requested review from
dcberg,
geeknoid,
linsun,
louiscryan,
rshriram and
smawson
as code owners
googlebot
added
the
cla: yes
istio-testing
added
the
size/S
Member
|
why doesn't it work? if I'm remembering correctly there was some bug with this that for fixed, but may be different can you give more details |
Contributor
Author
|
@howardjohn the k8s intorstring type has custom unmarshaller defined but not called when unmarshalling the k8s service type for jsobpb, so we need to mirror that type and its unmarshaller. I was trying to address that in previous operator PR: istio/operator#711. But since now we are using the new API in istio/api so I need to make the change here |
Contributor
Author
|
@howardjohn @ostromart @linsun Can you PTAL? This is blocking another operator fix: istio/operator#711 |
richardwxn
force-pushed
the
mirror-service
branch
from
7383d0d to
c7f739e
Compare
howardjohn
approved these changes
Jan 14, 2020
smawson
approved these changes
Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use custom type for k8s intorstring for operator with custom marshaller/unmarshaller, otherwise the unmarshaling would not work for targetport.
This change together with the operator PR would enable setting k8s service specs for IstioOperatorSpec