This repository was archived by the owner on Oct 7, 2020. It is now read-only.
fix ICP list unmarshal issue. #728
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
istio-testing
added
the
size/XS
Member
|
Can you link an issue or describe what is fixed or add a test? |
Member
|
@morvencao which issue will this pr fix? |
elfinhe
reviewed
Jan 3, 2020
Member
elfinhe
left a comment
elfinhe
left a comment
There was a problem hiding this comment.
LGTM. But I think this will be reverted in IstioOperatorList PR#713. Let's hold for a while and apply this change to IstioOperatorList.
|
@morvencao: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
istio-testing
added
the
needs-rebase
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add proto tag for standard list meta, to align with k8s API, eg: https://github.com/kubernetes/api/blob/master/core/v1/types.go#L3538-L3542