Open
Conversation
- Fix 8 security vulnerabilities (vite, ajv, js-yaml CVEs) - Migrate ESLint v8 to v9 with flat config (eslint.config.mjs) - Update React 19.0.0 to 19.2.4, Prettier 2.x to 3.x - Remove unused Babel presets/plugins and .babelrc (CRA leftovers) - Remove unused @tailwindcss/line-clamp - Update browserslist database
- Format src/index.css for Prettier 3 (changed font-family wrapping) - Audit only production deps (--omit=dev) since remaining minimatch vulnerabilities are in dev-only transitive dependencies
6 tasks
rimi-itk
reviewed
Feb 26, 2026
Comment on lines
+10
to
+18
| - Security and dependency updates | ||
| - Fix 8 security vulnerabilities (vite, ajv, js-yaml CVEs) | ||
| - Update React 19.0.0 to 19.2.4 | ||
| - Migrate ESLint v8 to v9 with flat config | ||
| - Update Prettier 2.x to 3.x | ||
| - Remove unused Babel presets (CRA leftovers) and `.babelrc` | ||
| - Remove unused `@tailwindcss/line-clamp` | ||
| - Update browserslist database | ||
|
|
Contributor
There was a problem hiding this comment.
I think we should discuss (again) how much detail we need in the changelog. This is way too detailed for my taste, but it may add value for others.
Contributor
There was a problem hiding this comment.
This project uses Prettier to check and format the code (cf. https://github.com/itk-dev/aapodwalk?tab=readme-ov-file#check-and-apply-with-prettier). Therefore we don't need this ESlint config file (I don't understand why we have/had .eslintrc.json file).
We probably have to clean up the project.
Comment on lines
-6
to
-8
| "@babel/plugin-transform-optional-chaining": "^7.24.8", | ||
| "@babel/preset-env": "^7.25.3", | ||
| "@babel/preset-react": "^7.24.7", |
Contributor
There was a problem hiding this comment.
Are we sure that we can safely remove this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
minimatchaudit warnings.babelrc)Vulnerability summary
minimatchin dev-only transitive deps)The remaining 9 are
minimatchReDoS in transitive dependencies of ESLint plugins and Tailwind's sucrase — dev-only, not shipped to production. These will resolve when upstream packages release updates.Changes
Phase 1 — Safe fixes
npm audit fix— patched vite (3 CVEs), ajv (ReDoS), js-yaml (prototype pollution)@babel/plugin-transform-optional-chaining,@babel/preset-env,@babel/preset-react,@tailwindcss/line-clamp.babelrcPhase 2 — ESLint v9 migration
eslint.config.mjseslint-config-airbnb,@babel/eslint-parser,eslint-plugin-only-warn,eslint-plugin-cypressprettier2→3,eslint-config-prettier8→10,eslint-plugin-react-hooks4→7--extflags)no-empty-patterninRoutesLoading.jsxFollow-up issues
Test plan
npm run buildpassesnpm run lint:jspasses (0 errors, 150 pre-existing warnings)docker run --rm --volume "$PWD:/work" tmknom/prettier:latest --check src