Skip to content

Law evaluation#130

Open
rimi-itk wants to merge 7 commits intodevelopfrom
feature/6814-law-track-evaluation
Open

Law evaluation#130
rimi-itk wants to merge 7 commits intodevelopfrom
feature/6814-law-track-evaluation

Conversation

@rimi-itk
Copy link
Contributor

@rimi-itk rimi-itk commented Feb 25, 2026

Link to ticket

https://leantime.itkdev.dk/dashboard/home#/tickets/showTicket/6814

Description

Refactors code to support multiple (and different) computations and evaluations. Implements computation and evaluation of “Law” stuff.

Screenshot of the result

If your change affects the user interface you should include a screenshot of the result with the pull request.

Checklist

  • My code is covered by test cases.
  • My code passes our test (all our tests).
  • My code passes our static analysis suite.
  • My code passes our continuous integration process.

If your code does not pass all the requirements on the checklist you have to add a comment explaining why this change
should be exempt from the list.

Additional comments or questions

If you have any further comments or questions for the reviewer please add them here.

@rimi-itk rimi-itk force-pushed the feature/6814-law-track-evaluation branch from 34045d3 to 9f80452 Compare February 25, 2026 12:02
@rimi-itk rimi-itk force-pushed the feature/6814-law-track-evaluation branch from d94484b to 71cbd4a Compare February 25, 2026 13:25
@rimi-itk rimi-itk requested a review from martinyde February 26, 2026 10:57
@rimi-itk rimi-itk marked this pull request as ready for review February 26, 2026 10:57
Copy link
Contributor

@martinyde martinyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to somehow handle the issue described

* 2: Hvis der forefindes ubesvarede spørgsmål, så skal scoringen være GUL
* 3: Hvis der forefindes Opgaver i rapporten, så skal scoringen være GUL.
*
* Scoringen kan således kun være GRØN, såfremt alle spørgsmål er besvarede,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note!

The original feature required two tasks to always be present on the law track report. This cannot currently be resolved by interacting with the webform:

https://github.com/itk-dev/ai-screening/blob/feature/6814-law-track-evaluation/web/themes/custom/itkdev/itkdev_project_theme/templates/components/webformSubmissionReportHeader.html.twig#L35-L45

@rimi-itk rimi-itk requested a review from martinyde February 26, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants