Skip to content

Conversation

@wiktordudek
Copy link
Contributor

No description provided.

@wiktordudek wiktordudek marked this pull request as draft July 17, 2025 21:36
Co-authored-by: Ákos Miklós <me@miklosakos.hu>
@itsvic-dev
Copy link
Owner

should we merge this now?

@wiktordudek
Copy link
Contributor Author

Yeah, sure 😄

@wiktordudek wiktordudek marked this pull request as ready for review July 20, 2025 15:01
@itsvic-dev
Copy link
Owner

conflicts should be resolved first

@Zan1456
Copy link
Contributor

Zan1456 commented Jul 20, 2025

Please wait for #160

@itsvic-dev
Copy link
Owner

Please wait for #160

#160 will take a while for me to review and i'd rather bring these in a future release. it's been a while since the last release and we really should release this ASAP to bring new services and crash fixes to users

@Zan1456
Copy link
Contributor

Zan1456 commented Jul 20, 2025

Once I'm home, I'm going to push the express One support

@itsvic-dev
Copy link
Owner

Once I'm home, I'm going to push the express One support

please do so in a separate PR/branch and we'll merge it for 1.4.0.

@wiktordudek
Copy link
Contributor Author

Can we please avoid adding any new features at the last minute? I’ve already tested everything before this particular release.

Testing your changes will take some time, and definitely shouldn’t be merged right before the release of the new version.

@itsvic-dev
Copy link
Owner

itsvic-dev commented Jul 20, 2025

Can we please avoid adding any new features at the last minute? I’ve already tested everything before this particular release.

Testing your changes will take some time, and definitely shouldn’t be merged right before the release of the new version.

i would like to review and merge at the very least Express One support, as Zan already has a working version in their tree.
image

@Zan1456
Copy link
Contributor

Zan1456 commented Jul 20, 2025

Forget it, as I'd have to rewrite some of the code, since it's different because of the categorization.

@wiktordudek
Copy link
Contributor Author

wiktordudek commented Jul 20, 2025

Okay, let's merge it

@itsvic-dev itsvic-dev merged commit 1a3dc86 into itsvic-dev:master Jul 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants