add error handling to avoid crashes on API parsing #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsvic-dev
reviewed
Oct 30, 2025
Owner
itsvic-dev
left a comment
itsvic-dev
left a comment
There was a problem hiding this comment.
one minor nitpick, but everything lgtm. thank you!
app/src/main/java/dev/itsvic/parceltracker/api/UPSDeliveryService.kt
Outdated
Show resolved
Hide resolved
stendler
force-pushed
the
fix/error-handling
branch
from
26d3610 to
b9fc828
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On JSON data conversion error or any other RuntimeException, instead of crashing and possibly creating an unremovable parcel entry, create a parcel error entry instead with an error message.
The message may also help with further troubleshooting on user reports.