Fix Allegro OneBox tracking showing incorrect time #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API returns UTC timestamps but they were being parsed as local time using LocalDateTime.parse(). This caused times to be displayed incorrectly for users not in the UTC timezone. Fixed by using Instant.parse() to properly interpret the UTC timestamp, then converting to local time using LocalDateTime.ofInstant() with the system's default timezone. Fixes itsvic-dev#187
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes Made
AllegroOneBoxDeliveryService.ktto useInstant.parse()+LocalDateTime.ofInstant()BelpostDeliveryServiceandCainiaoDeliveryServiceDateTimeFormatterimportTechnical Details
The API returns timestamps in ISO 8601 format with UTC timezone (e.g.,
2024-01-15T10:30:00Z). Previously,LocalDateTime.parse()was used which ignores the timezone suffix and interprets the time as local. Now we properly parse it as anInstant(UTC) and convert to local time.Test Plan
localDateFromMilli()in Core.ktFixes #187