Skip to content

board: Add support for Samsung Galaxy S9+ (star2lte)#60

Open
RealFX-Code wants to merge 3 commits intoivoszbg:masterfrom
RealFX-Code:master
Open

board: Add support for Samsung Galaxy S9+ (star2lte)#60
RealFX-Code wants to merge 3 commits intoivoszbg:masterfrom
RealFX-Code:master

Conversation

@RealFX-Code
Copy link

This adds support for Samsung Galaxy S9+.

Seems to work for me locally.

@BotchedRPR
Copy link
Collaborator

@ivoszbg Your call :)

@R0rt1z2
Copy link
Contributor

R0rt1z2 commented Nov 13, 2025

Not my call, but might be worth adding this device to the supported devices list in the README? I'm not sure if it differs much from starlte

@BotchedRPR
Copy link
Collaborator

Not my call, but might be worth adding this device to the supported devices list in the README? I'm not sure if it differs much from starlte

the readme is currently really rough, it'll get replaced soon, but yeah, good note :)

@RealFX-Code
Copy link
Author

Not my call, but might be worth adding this device to the supported devices list in the README? I'm not sure if it differs much from starlte

It is pretty much starlte's defconfig and board file, except I had to swap the width and height for the framebuffer.

Also did add it to the device list.

@ivoszbg
Copy link
Owner

ivoszbg commented Nov 14, 2025

Not my call, but might be worth adding this device to the supported devices list in the README? I'm not sure if it differs much from starlte

It is pretty much starlte's defconfig and board file, except I had to swap the width and height for the framebuffer.

Also did add it to the device list.

So why not just use the starlte board file? I see no reason for having 3 commits for all of this.

@RealFX-Code
Copy link
Author

Not my call, but might be worth adding this device to the supported devices list in the README? I'm not sure if it differs much from starlte

It is pretty much starlte's defconfig and board file, except I had to swap the width and height for the framebuffer.
Also did add it to the device list.

So why not just use the starlte board file? I see no reason for having 3 commits for all of this.

I had to move some stuff around and I don't have a regular S9 to test it on.

@evilMyQueen
Copy link
Contributor

realfx-code, why dont just try it like ivoszbg said. Make a star2lte_defconfig, add device to readme.md, add the device to board/Kconfig and just let it build the starlte board. So that both CONFIG_SAMSUNG_STARLTE and CONFIG_SAMSUNG_STAR2LTE build board/samsung/board-starlte.o. Btw rebase ur fork

@evilMyQueen
Copy link
Contributor

Also squash it all, it will be much cleaner. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments