Fix Prometheus metrics registration and duplicate collection #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… builder and add disk I/O monitoring
iyashjayesh
changed the title
iyashjayesh
added a commit
that referenced
this pull request
Jan 23, 2026
* Improve Port error handling and fix docs (#30) * fix: improve error handling for address in use * feat: add helper to return the port in use * revert: revert port in example to 8080 * docs: remove duplicate func keyword * Fix Prometheus metrics registration and duplicate collection (#29) * update readme * update readme * update readme * update readme * feat: Implement time-series storage with tstorage, introduce a config builder and add disk I/O monitoring * Fix Prometheus metrics registration and duplicate collection * updated compreshensive example * updated go mod * Improve Port error handling and fix docs (#30) (#31) * fix: improve error handling for address in use * feat: add helper to return the port in use * revert: revert port in example to 8080 * docs: remove duplicate func keyword Co-authored-by: emmadal <emmanueldalougou@gmail.com> --------- Co-authored-by: emmadal <emmanueldalougou@gmail.com> --------- Co-authored-by: emmadal <emmanueldalougou@gmail.com>
iyashjayesh
added a commit
that referenced
this pull request
Jan 26, 2026
…ion (#34) * update readme * update readme * update readme * update readme * feat: Implement time-series storage with tstorage, introduce a config builder and add disk I/O monitoring * Fix Prometheus metrics registration and duplicate collection * updated compreshensive example * updated go mod * Improve Port error handling and fix docs (#30) (#31) * fix: improve error handling for address in use * feat: add helper to return the port in use * revert: revert port in example to 8080 * docs: remove duplicate func keyword Co-authored-by: emmadal <emmanueldalougou@gmail.com> * feat() impl asynchronous telemetry Pipeline and Storage Abstractions * rebase (#35) * Improve Port error handling and fix docs (#30) * fix: improve error handling for address in use * feat: add helper to return the port in use * revert: revert port in example to 8080 * docs: remove duplicate func keyword * Fix Prometheus metrics registration and duplicate collection (#29) * update readme * update readme * update readme * update readme * feat: Implement time-series storage with tstorage, introduce a config builder and add disk I/O monitoring * Fix Prometheus metrics registration and duplicate collection * updated compreshensive example * updated go mod * Improve Port error handling and fix docs (#30) (#31) * fix: improve error handling for address in use * feat: add helper to return the port in use * revert: revert port in example to 8080 * docs: remove duplicate func keyword Co-authored-by: emmadal <emmanueldalougou@gmail.com> --------- Co-authored-by: emmadal <emmanueldalougou@gmail.com> --------- Co-authored-by: emmadal <emmanueldalougou@gmail.com> * udpate: readme and WithSamplingRate, WithStorageType, WithHeadless for config builder --------- Co-authored-by: emmadal <emmanueldalougou@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MonigoCollectorininit()to ensure custom metrics are actually exposed.Collect()to fix "metric collected before" runtime errors.