Avoid warning related to locale.getdefaultlocale deprecation #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When tkfilebrowser is used inside a project, the code produces a DeprecationWarning due to the use of locale.getdefaultlocale. See python/cpython#90817 Solution based on getdefaultlocale's help and CPython's own code in the calendar.LocaleTextCalendar class. Commit: python/cpython@4fccf91
so it can be obtained within _getdefaultlocale
Do some shennanigans with what Windows returns to try to get a valid language parse using babel Locale aliases. Using babel.Locale preserves more locale information for the formatting function calls.
Author
|
Please check PR #34 before this one, as it may be the most ellegant solution for these two PR (32 and 33) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tkfilebrowser is used inside a project, the code produces a DeprecationWarning due to the use of locale.getdefaultlocale.
See python/cpython#90817
Solution based on getdefaultlocale's help and CPython's own code in the calendar.LocaleTextCalendar class. Commit:
python/cpython@4fccf91