Fix first-load track selection and media request rendering#1
Open
EclipseKnight wants to merge 3 commits intoj4ckgrey:mainfrom
Open
Fix first-load track selection and media request rendering#1EclipseKnight wants to merge 3 commits intoj4ckgrey:mainfrom
EclipseKnight wants to merge 3 commits intoj4ckgrey:mainfrom
Conversation
Resolve stream metadata requests in a stricter fallback order to avoid false 404s when switching versions:\n- resolve by itemId first\n- fallback to mediaSourceId as item id\n- fallback to Gelato guid in ExternalId on gelato-stream rows\n\nThis keeps version/audio/subtitle dropdown population stable when the request carries a stale/virtual item id.
Collaborator
Author
|
I pushed one additional fix commit to this same branch: dc6064a fix(streams): make metadata stream lookup resilient on version switch Why: What changed: Resolve by itemId first (normal path) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tracked a few Cavea issues that were all related to first-load behavior and request rendering.
Main problems:
What I changed:
Api/StreamController.csGetPlaybackMediaSourcesselectedsetAudioStreamIndex/SubtitleStreamIndexand defaults) so previous-item behavior is respectedFiles/wwwroot/select-to-cards.jsselectedflags when building dropdown optionsFiles/wwwroot/requests.jsstatusanditemTypeconsistentlytmdbMediaTypeas fallback for type routingurl(...), quotes,&) and appendapi_keyfor same-origin/Items/...poster urlsManual checks: