fix: Fixes an issue with strings that starts with numbers#10
Merged
photomattmills merged 1 commit intojackpocket:mainfrom Feb 26, 2025
Merged
fix: Fixes an issue with strings that starts with numbers#10photomattmills merged 1 commit intojackpocket:mainfrom
photomattmills merged 1 commit intojackpocket:mainfrom
Conversation
Contributor
|
This is a good catch! Let me see if I can get the CI working, you might need to rebase that once it's up. |
Contributor
|
CI should work if you rebase on |
…number representation
Contributor
Author
|
Hi @photomattmills, I rebased the |
photomattmills
approved these changes
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
When using
PDF417.encodeorPDF417.encode_to_base64with a string that starts with a number and is greater than 13 digits, theNumberCompactor.compactable?is returningtruedue toInteger.parse(part)returning an output like{number, rest of string}i.e a string like
74cLlWZPjVWX02when callingInteger.parse("74cLlWZPjVWX02")it returns{74, "cLlWZPjVWX02"}and then later when usingString.to_integer()in thedef compact(part)function, it raises an error1st argument: not a textual representation of an integerbecause it is not a string integer representation.Instead of using
Integer.parse, we can use a regex to only accept strings with numbers (string integer representation)