Catapp with mongoose feedback #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge this pull request!
Homework Feedback for Cat App with Mongoose:
Functionality:
All of the required features work!
The createToy function does not work because toys is a property of each cat within allCats,
not a property of allCats. If you want to try out embedding again, you will probably know how to do this now! Nice job trying out an additional/challenging feature. Your advanced query was functional.
The only bugs were in the additional challenges portion of the assignment, so you will not lose any points for those.
Completion: (20/20)
Bug Free: (10/10)
Quality:
You followed good coding practices throughout! Your code was very readable.
It looks like you forgot to put a comment explaining what the gteCat function does, and spacing could be a little more consistent.
Good Coding Practices: (10/10)
Readability: (9/10)
Summary:
Nice work! Your advanced query worked and it was awesome to start trying out something more challenging. You had a great handle on how to integrate the mongo database!
(49/50)