fix: update test_geonames_query to assert coordinates as a dict with …

[jairomelo]

…latitude and longitude

[Copilot]

Pull Request Overview

This PR updates the test_geonames_query to assert that resolver.resolve returns a dictionary with latitude and longitude keys and validates the expected coordinates for New York, US.

• Changed return type assertion from tuple to dict
• Added key presence checks for latitude and longitude
• Added strict value comparison for the expected coordinates

Comments suppressed due to low confidence (1)

tests/test_resolver.py:19

• [nitpick] The numbering prefix '2.' in the assertion message is unnecessary and may clutter output; remove it for clearer error messages.

    assert isinstance(coordinates, dict), "2. Coordinates should be a dict"

[Copilot]

[nitpick] The explicit None check may be redundant as subsequent assertions will fail on None; consider removing it to simplify the test.

Suggested change

	assert coordinates is not None, "1. Coordinates should not be None"
	assert isinstance(coordinates, dict), "2. Coordinates should be a dict"
	assert "latitude" in coordinates and "longitude" in coordinates, "3. Coordinates should contain latitude and longitude"
	assert coordinates["latitude"] == 40.71427 and coordinates["longitude"] == -74.00597, f"4. Coordinates {coordinates} do not match expected values for New York, US"
	assert isinstance(coordinates, dict), "1. Coordinates should be a dict"
	assert "latitude" in coordinates and "longitude" in coordinates, "2. Coordinates should contain latitude and longitude"
	assert coordinates["latitude"] == 40.71427 and coordinates["longitude"] == -74.00597, f"3. Coordinates {coordinates} do not match expected values for New York, US"

[Copilot]

Directly comparing floats can lead to flaky tests; consider using pytest.approx for approximate comparisons of latitude and longitude values.