Add typescript types to package exports#192
Closed
jonrouleau wants to merge 1 commit intojamiebuilds:mainfrom
Closed
Add typescript types to package exports#192jonrouleau wants to merge 1 commit intojamiebuilds:mainfrom
jonrouleau wants to merge 1 commit intojamiebuilds:mainfrom
Conversation
|
I ran into the exact same issue, and this solved it perfectly. |
|
Please merge this. We cannot deploy due to this issue!! |
|
necessary indeed |
|
Ran into the same thing. |
|
I felt smart in attempting to fix this temporarily using patch-package, but apparently one can't easily patch a package's So the only options are:
|
|
@jamiebuilds please merge this |
|
@jrouleau, why did you close this/ delete the head repository? |
Author
|
@jrouleau alright, but does it get merged? It's open for a while now. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #191